From 9fc70cdbca04321c5c33e7ca5662e4f88cf8ef88 Mon Sep 17 00:00:00 2001
From: steve-lad <72376554+steve-lad@users.noreply.github.com>
Date: Wed, 14 Jul 2021 15:09:06 +0200
Subject: [PATCH] Replace mkringlist.sh with mkringlist.php

Move from tftpboot/ringtones to Tools
Use PHP instead of Bash to simplify output
Eliminate executables in tftpboot
---
 tftpboot/ringtones/mkringlist.sh |  23 ------
 tftpboot/ringtones/ringlist.xml  | 121 ++++++++++++++++---------------
 tools/mkringlist.php             |  34 +++++++++
 3 files changed, 95 insertions(+), 83 deletions(-)
 delete mode 100755 tftpboot/ringtones/mkringlist.sh
 create mode 100644 tools/mkringlist.php

diff --git a/tftpboot/ringtones/mkringlist.sh b/tftpboot/ringtones/mkringlist.sh
deleted file mode 100755
index f68c9b7..0000000
--- a/tftpboot/ringtones/mkringlist.sh
+++ /dev/null
@@ -1,23 +0,0 @@
-#!/usr/bin/env bash
-outfile=ringlist.xml
-echo -e "<CiscoIPPhoneRingList>" >$outfile
-if [ ! -z "`ls *.pcm 2>/dev/null`" ]; then
-	for filename in *.pcm;do
-		basename=`basename ${filename} .pcm`
-		echo -e "\t<Ring>" >>$outfile
-		echo -e "\t\t<DisplayName>${basename}</DisplayName>" >>$outfile
-		echo -e "\t\t<FileName>ringtones/${filename}</FileName>" >>$outfile
-		echo -e "\t</Ring>" >>$outfile
-	done
-fi
-if [ ! -z "`ls *.raw 2>/dev/null`" ]; then
-	for filename in *.raw;do
-		basename=`basename ${filename} .raw`
-		echo -e "\t<Ring>" >>$outfile
-		echo -e "\t\t<DisplayName>${basename}</DisplayName>" >>$outfile
-		echo -e "\t\t<FileName>ringtones/${filename}</FileName>" >>$outfile
-		echo -e "\t</Ring>" >>$outfile
-	done
-fi
-echo -e "</CiscoIPPhoneRingList>" >>$outfile
-
diff --git a/tftpboot/ringtones/ringlist.xml b/tftpboot/ringtones/ringlist.xml
index 219a246..e9230d1 100644
--- a/tftpboot/ringtones/ringlist.xml
+++ b/tftpboot/ringtones/ringlist.xml
@@ -1,62 +1,63 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <CiscoIPPhoneRingList>
-	<Ring>
-		<DisplayName>drums1</DisplayName>
-		<FileName>ringtones/drums1.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>drums2</DisplayName>
-		<FileName>ringtones/drums2.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>loudc1</DisplayName>
-		<FileName>ringtones/loudc1.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>loudc2</DisplayName>
-		<FileName>ringtones/loudc2.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>loudlaser</DisplayName>
-		<FileName>ringtones/loudlaser.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>merlin2</DisplayName>
-		<FileName>ringtones/merlin2.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>merlin3</DisplayName>
-		<FileName>ringtones/merlin3.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>merlin4</DisplayName>
-		<FileName>ringtones/merlin4.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>merlin5</DisplayName>
-		<FileName>ringtones/merlin5.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>merlin6</DisplayName>
-		<FileName>ringtones/merlin6.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>merlin7</DisplayName>
-		<FileName>ringtones/merlin7.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>ringer1</DisplayName>
-		<FileName>ringtones/ringer1.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>ringer2</DisplayName>
-		<FileName>ringtones/ringer2.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>ringer3</DisplayName>
-		<FileName>ringtones/ringer3.pcm</FileName>
-	</Ring>
-	<Ring>
-		<DisplayName>ringer4</DisplayName>
-		<FileName>ringtones/ringer4.pcm</FileName>
-	</Ring>
+  <Ring>
+    <DisplayName>drums1</DisplayName>
+    <FileName>ringtones/drums1.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>drums2</DisplayName>
+    <FileName>ringtones/drums2.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>loudc1</DisplayName>
+    <FileName>ringtones/loudc1.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>loudc2</DisplayName>
+    <FileName>ringtones/loudc2.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>loudlaser</DisplayName>
+    <FileName>ringtones/loudlaser.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>merlin2</DisplayName>
+    <FileName>ringtones/merlin2.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>merlin3</DisplayName>
+    <FileName>ringtones/merlin3.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>merlin4</DisplayName>
+    <FileName>ringtones/merlin4.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>merlin5</DisplayName>
+    <FileName>ringtones/merlin5.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>merlin6</DisplayName>
+    <FileName>ringtones/merlin6.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>merlin7</DisplayName>
+    <FileName>ringtones/merlin7.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>ringer1</DisplayName>
+    <FileName>ringtones/ringer1.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>ringer2</DisplayName>
+    <FileName>ringtones/ringer2.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>ringer3</DisplayName>
+    <FileName>ringtones/ringer3.pcm</FileName>
+  </Ring>
+  <Ring>
+    <DisplayName>ringer4</DisplayName>
+    <FileName>ringtones/ringer4.pcm</FileName>
+  </Ring>
 </CiscoIPPhoneRingList>
diff --git a/tools/mkringlist.php b/tools/mkringlist.php
new file mode 100644
index 0000000..eee12e2
--- /dev/null
+++ b/tools/mkringlist.php
@@ -0,0 +1,34 @@
+<?php
+
+//Usage: php mkringlist.php;
+
+function createCats($currDirPos){
+
+   $xml = '';
+
+   if(is_dir($currDirPos)){
+       // Remove unix ./..
+       foreach (array_diff(scandir($currDirPos),array('.','..')) as $subDir) {
+           //remove link information
+           $subDir = explode(' ', $subDir);
+						$displayName = explode('.',$subDir[0]);
+           $fileName = str_replace('../tftpboot/','',$currDirPos) .'/'. $subDir[0];
+           if (in_array($displayName[1], array('pcm','raw'))) {
+   						$xml .= "<Ring><DisplayName>{$displayName[0]}</DisplayName><FileName>{$fileName}</FileName></Ring>";
+           }
+       }
+   }
+   return $xml;
+}
+
+function saveXml($xml, $filename) {
+   $xml = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>'.'<CiscoIPPhoneRingList>' . $xml . '</CiscoIPPhoneRingList>';
+   $dom = new \DOMDocument("1.0");
+   $dom->preserveWhiteSpace = false;
+   $dom->formatOutput = true;
+   $dom->loadXML($xml);
+   $dom->save($filename);
+}
+
+saveXml(createCats('../tftpboot/ringtones'),'../tftpboot/ringtones/ringlist.xml');
+?>