mirror/provision_sccp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make config instantiation private

Browse Source 
Fixup Paths
Moved all tests to phpunit tests

Signed-off-by: Diederik de Groot <ddegroot@talon.nl>
This commit is contained in:
Diederik de Groot
2020-03-18 11:57:30 +01:00
parent c535113c55
commit 3e9f731e9a
5 changed files with 87 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
tests/resolverTest.php
View File

@@ -1,17 +1,60 @@
<?php declare(strict_types=1);
use PHPUnit\Framework\TestCase;
include_once "lib/resolver.php";
include_once "lib/resolve.php";
use SCCP\Resolve as Resolve;
final class ResolverTest extends TestCase
{
private function getConfig()
{
global $base_path;
$configParser = new SCCP\Config\ConfigParser($base_path, "config.ini");
return $configParser->getConfiguration();
}
public function testCanBeCreated(): void
{
global $config;
$resolver = new \SCCP\Resolve\Resolver($config);
//global $config;
$config = $this->getConfig();
$resolve = new \SCCP\Resolve\Resolve($config);
$this->assertInstanceOf(
\SCCP\Resolve\Resolver::class,
$resolver
\SCCP\Resolve\Resolve::class,
$resolve
);
}
private $test_cases = Array(
Array('request' => 'jar70sccp.9-4-2ES26.sbn', 'expected' => '/data/firmware/7970/jar70sccp.9-4-2ES26.sbn'),
Array('request' => 'Russian_Russian_Federation/be-sccp.jar', 'expected' => '/data/locales/languages/Russian_Russian_Federation/be-sccp.jar'),
Array('request' => 'Spain/g3-tones.xml', 'expected' => '/data/locales/countries/Spain/g3-tones.xml'),
Array('request' => '320x196x4/Chan-SCCP-b.png', 'expected' => '/data/wallpapers/320x196x4/Chan-SCCP-b.png'),
Array('request' => 'XMLDefault.cnf.xml', 'expected' => '/data/settings/XMLDefault.cnf.xml'),
Array('request' => '../XMLDefault.cnf.xml', 'expected' => Resolve\ResolveResult::RequestContainsPathWalk),
Array('request' => 'XMLDefault.cnf.xml/../../text.xml', 'expected' => Resolve\ResolveResult::RequestContainsPathWalk),
);
public function testCanResolveFiles(): void
{
global $base_path;
$config = $this->getConfig();
//global $config;
$resolve = new \SCCP\Resolve\Resolve($config);
foreach($this->test_cases as $test) {
try {
$result = $resolve->resolve($test['request']);
if (is_string($result)) {
$this->assertStringContainsString($result, $base_path . $test['expected']);
} else {
$this->assertEquals($result, $test['expected']);
}
} catch (Exception $e) {
print("'" . $test['request'] . "' => throws error as expected\n");
print("Exception: " . $e->getMessage() . "\n");
}
}
unset($resolve);
}
}