Addressing review comments and adding a note to also set INSTALL_REPOS to true to enable copr repo

This commit is contained in:
Ben Erickson
2025-01-29 10:24:48 -08:00
parent 8e4bbcf8e4
commit 0ef03683b3
3 changed files with 6 additions and 4 deletions

View File

@@ -49,7 +49,7 @@ Supported Linux distributions and versions:
- Ubuntu 22.04 - Ubuntu 22.04
- Ubuntu 20.04 - Ubuntu 20.04
NOTE: By default, libvhdi-tools is not installed on RHEL based distros; so file-level restores from delta backups within XOA will not work. However, users MAY install libvhdi-tools via a small, third-party maintained by a user of XenOrchestraInstallerUpdater specifically for XenOrchestraInstallerUpdater in order to re-enable file-level restore. To do so, set the INSTALL_EL_LIBVHDI variable to "true" in xo-install.cfg. See: https://github.com/ronivay/XenOrchestraInstallerUpdater/pull/274 NOTE: By default, libvhdi-tools is not installed on RHEL based distros; so file-level restores from delta backups within XO will not work. However, users MAY install libvhdi-tools via a small, third-party maintained by a user of XenOrchestraInstallerUpdater specifically for XenOrchestraInstallerUpdater in order to re-enable file-level restore. To do so, set the INSTALL_EL_LIBVHDI variable to "true" in xo-install.cfg. See: https://github.com/ronivay/XenOrchestraInstallerUpdater/pull/274
Only x86_64 architecture is supported. For all those raspberry pi users out there, check [container](https://hub.docker.com/r/ronivay/xen-orchestra) instead. Only x86_64 architecture is supported. For all those raspberry pi users out there, check [container](https://hub.docker.com/r/ronivay/xen-orchestra) instead.

View File

@@ -122,8 +122,9 @@ PRESERVE="3"
#INSTALL_REPOS="true" #INSTALL_REPOS="true"
# If set to true, this will install a small third-party copr repository necessary to install the libvhdi and libvhdi-tools rpms as-well-as the libvhdi and libvhdi-tools rpms. # If set to true, this will install a small third-party copr repository necessary to install the libvhdi and libvhdi-tools rpms as-well-as the libvhdi and libvhdi-tools rpms.
# If set to false, this repository and the corresponding libvhdi and libvhdi-tools rpms will not be installed. As as result, file-level restore from delta backups within XOA will NOT work. # If set to false, this repository and the corresponding libvhdi and libvhdi-tools rpms will not be installed. As as result, file-level restore from delta backups within XO will NOT work.
# This is specific to Redhat/RockyLinux/AlmaLinux installs ONLY. # This is specific to Redhat/RockyLinux/AlmaLinux installs ONLY.
# Note that INSTALL_REPOS must also be set to "true" for the copr repository to be enabled.
# options: true/false # options: true/false
# default: false # default: false
#INSTALL_EL_LIBVHDI="false" #INSTALL_EL_LIBVHDI="false"

View File

@@ -49,6 +49,7 @@ ACME_EMAIL="${ACME_EMAIL:-""}"
ACME_CA="${ACME_CA:-"letsencrypt/production"}" ACME_CA="${ACME_CA:-"letsencrypt/production"}"
USESUDO="${USESUDO:-"false"}" USESUDO="${USESUDO:-"false"}"
GENSUDO="${GENSUDO:-"false"}" GENSUDO="${GENSUDO:-"false"}"
INSTALL_EL_LIBVHDI="${INSTALL_EL_LIBVHDI:-"false"}"
INSTALL_REPOS="${INSTALL_REPOS:-"true"}" INSTALL_REPOS="${INSTALL_REPOS:-"true"}"
SYSLOG_TARGET="${SYSLOG_TARGET:-""}" SYSLOG_TARGET="${SYSLOG_TARGET:-""}"
YARN_CACHE_CLEANUP="${YARN_CACHE_CLEANUP:-"false"}" YARN_CACHE_CLEANUP="${YARN_CACHE_CLEANUP:-"false"}"
@@ -250,9 +251,9 @@ function InstallDependenciesRPM {
printprog "Installing libvhdi-tools" printprog "Installing libvhdi-tools"
if [[ "$INSTALL_REPOS" == "true" ]] && [[ "$INSTALL_EL_LIBVHDI" == "true" ]]; then if [[ "$INSTALL_REPOS" == "true" ]] && [[ "$INSTALL_EL_LIBVHDI" == "true" ]]; then
runcmd "dnf copr enable -y bnerickson/libvhdi" runcmd "dnf copr enable -y bnerickson/libvhdi"
else
runcmd "dnf install -y libvhdi-tools"
fi fi
runcmd "dnf install -y libvhdi-tools"
printok "Installing libvhdi-tools" printok "Installing libvhdi-tools"
fi fi